Merged
Conversation
BenFordTytherington
force-pushed
the
base-on-cppqt-blocks
branch
from
0d564d5 to
52b9f7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12527 12585 +58
=========================================
+ Hits 12527 12585 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
base-on-cppqt-blocks
branch
2 times, most recently
from
d752ddb to
1ee7958
Compare
BenFordTytherington
force-pushed
the
base-on-cppqt-blocks
branch
from
6ed9dda to
9f06cf3
Compare
- Also add automatic casting for applicable cases - Update an unnecessary C++Qt block to C++ in cxx_qt_lib
BenFordTytherington
force-pushed
the
base-on-cppqt-blocks
branch
from
e55b428 to
9ea5a60
Compare
ahayzen-kdab
approved these changes
Mar 7, 2025
Collaborator
ahayzen-kdab
left a comment
ahayzen-kdab
left a comment
There was a problem hiding this comment.
LGTM, further improvements to the casting can go in further changes. This is useful by itself :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
#[base = T]attribute inextern "C++Qt"blocks, as well as casting implementations for these applicable types.